From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: PPC: Add generic hpte management functions Date: Tue, 22 Jun 2010 15:20:43 +0300 Message-ID: <4C20AA9B.8000807@redhat.com> References: <1277127841-32704-1-git-send-email-agraf@suse.de> <4C20A64D.2070805@redhat.com> <4C20A6C8.4070002@suse.de> <4C20A795.6040607@redhat.com> <4C20A836.2010908@suse.de> <4C20A890.9040806@redhat.com> <4C20A91A.1080607@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: <4C20A91A.1080607-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 06/22/2010 03:14 PM, Alexander Graf wrote: > Avi Kivity wrote: > >> On 06/22/2010 03:10 PM, Alexander Graf wrote: >> >>> If you have more performance hints, I'll gladly take them :). >>> >>> >> Using a cpu that virtualizes the mmu in hardware helps tremendously. >> >> > PPC never does that. Even with the virtualization extensions the MMU is > still software managed. Then mmu intensive loads can expect to be slow. > I was also more thinking of hints like > "kmem_cache_zalloc is slow" or so ;). > Stuff like that is usually worthless. To give real feedback I need to understand the hardware, so I'm reduced to coding style and indentation review. -- error compiling committee.c: too many arguments to function