From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] do not enter vcpu again if it was stopped during IO Date: Wed, 23 Jun 2010 11:22:15 +0300 Message-ID: <4C21C437.7050302@redhat.com> References: <20100621090152.GG4689@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34180 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209Ab0FWIWR (ORCPT ); Wed, 23 Jun 2010 04:22:17 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5N8MHcA004684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jun 2010 04:22:17 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5N8MGvo028774 for ; Wed, 23 Jun 2010 04:22:17 -0400 In-Reply-To: <20100621090152.GG4689@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/21/2010 12:01 PM, Gleb Natapov wrote: > To prevent reentering vcpu after IO completion it is not enough > to set env->stopped since it is checked only in main loop but control > will not get there until next non-IO exit since kvm_run() will reenter > vcpu to complete IO instruction. Solve this by sending self-signal to > request exit after IO instruction completion. > > Applied, thanks. Does uq/master need such a patch? -- error compiling committee.c: too many arguments to function