public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu
Date: Wed, 23 Jun 2010 15:29:28 +0300	[thread overview]
Message-ID: <4C21FE28.1040704@redhat.com> (raw)
In-Reply-To: <20100323163812.726785030@redhat.com>

On 03/23/2010 06:37 PM, Marcelo Tosatti wrote:
> This is now done via the initialization's qemu_system_reset call.
>
>
> Index: qemu-uq/kvm-all.c
> ===================================================================
> --- qemu-uq.orig/kvm-all.c
> +++ qemu-uq/kvm-all.c
> @@ -209,7 +209,6 @@ int kvm_init_vcpu(CPUState *env)
>       ret = kvm_arch_init_vcpu(env);
>       if (ret == 0) {
>           qemu_register_reset(kvm_reset_vcpu, env);
> -        kvm_arch_reset_vcpu(env);
>       }
>   err:
>       return ret;
>
>
>    

I'm testing uq/master, and I see this breaks it.  qemu freezes 
immediately on startup.

(might be due to a rebase?)

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-06-23 12:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 16:37 [patch 0/6] misc uq/master updates (v2) Marcelo Tosatti
2010-03-23 16:37 ` [patch 1/6] target-i386: print EFER in cpu_dump_state Marcelo Tosatti
2010-03-23 16:37 ` [patch 2/6] kvm: handle internal error Marcelo Tosatti
2010-03-23 16:37 ` [patch 3/6] kvm: allow qemu to set EPT identity mapping address Marcelo Tosatti
2010-03-23 16:37 ` [patch 4/6] kvm_init_vcpu requires global lock held Marcelo Tosatti
2010-03-23 16:37 ` [patch 5/6] kvm: init mp_state Marcelo Tosatti
2010-03-23 16:37 ` [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Marcelo Tosatti
2010-06-23 12:29   ` Avi Kivity [this message]
2010-06-23 12:33     ` Avi Kivity
2010-06-23 13:19       ` Jan Kiszka
2010-06-23 13:26         ` Avi Kivity
2010-06-23 13:29           ` Jan Kiszka
2010-06-23 13:34             ` Avi Kivity
2010-03-24 10:00 ` [patch 0/6] misc uq/master updates (v2) Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C21FE28.1040704@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox