From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Date: Wed, 23 Jun 2010 15:33:36 +0300 Message-ID: <4C21FF20.4030706@redhat.com> References: <20100323163709.033115262@redhat.com> <20100323163812.726785030@redhat.com> <4C21FE28.1040704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab0FWMdi (ORCPT ); Wed, 23 Jun 2010 08:33:38 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5NCXc9G011063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jun 2010 08:33:38 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5NCXbLZ027686 for ; Wed, 23 Jun 2010 08:33:37 -0400 In-Reply-To: <4C21FE28.1040704@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/23/2010 03:29 PM, Avi Kivity wrote: > On 03/23/2010 06:37 PM, Marcelo Tosatti wrote: >> This is now done via the initialization's qemu_system_reset call. >> >> >> Index: qemu-uq/kvm-all.c >> =================================================================== >> --- qemu-uq.orig/kvm-all.c >> +++ qemu-uq/kvm-all.c >> @@ -209,7 +209,6 @@ int kvm_init_vcpu(CPUState *env) >> ret = kvm_arch_init_vcpu(env); >> if (ret == 0) { >> qemu_register_reset(kvm_reset_vcpu, env); >> - kvm_arch_reset_vcpu(env); >> } >> err: >> return ret; >> >> > > I'm testing uq/master, and I see this breaks it. qemu freezes > immediately on startup. > > (might be due to a rebase?) > The symptoms, btw, are a vcpu started from 0:0 instead of 0xf000:0xfff0. -- error compiling committee.c: too many arguments to function