From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] device-assignment: be more selective in interrupt disabling Date: Wed, 23 Jun 2010 16:05:59 +0300 Message-ID: <4C2206B7.2070409@redhat.com> References: <20100617174948.4792.54699.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, chrisw@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19292 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423Ab0FWNGB (ORCPT ); Wed, 23 Jun 2010 09:06:01 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5ND61TC010589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Jun 2010 09:06:01 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5ND603q031832 for ; Wed, 23 Jun 2010 09:06:00 -0400 In-Reply-To: <20100617174948.4792.54699.stgit@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 06/17/2010 08:51 PM, Alex Williamson wrote: > An 82576 physical function assigned to a Windows 7 guest currently > doesn't work because the driver seems to gratuitiously disable > MSI and MSIX interrupts. When it does this, we blindly deassign > the current interrupt setup, leaving the device with no interrupts. > Instead let's only deassign the irq if we were previously using > MSI/MSIX or if we're going to start using MSI/MSIX. > Applied, thanks. -- error compiling committee.c: too many arguments to function