Re: [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu

[Jan Kiszka <jan.kiszka@siemens.com>]

Avi Kivity wrote:
> On 06/23/2010 03:29 PM, Avi Kivity wrote:
>> On 03/23/2010 06:37 PM, Marcelo Tosatti wrote:
>>> This is now done via the initialization's qemu_system_reset call.
>>>
>>>
>>> Index: qemu-uq/kvm-all.c
>>> ===================================================================
>>> --- qemu-uq.orig/kvm-all.c
>>> +++ qemu-uq/kvm-all.c
>>> @@ -209,7 +209,6 @@ int kvm_init_vcpu(CPUState *env)
>>>       ret = kvm_arch_init_vcpu(env);
>>>       if (ret == 0) {
>>>           qemu_register_reset(kvm_reset_vcpu, env);
>>> -        kvm_arch_reset_vcpu(env);
>>>       }
>>>   err:
>>>       return ret;
>>>
>>>
>>
>> I'm testing uq/master, and I see this breaks it.  qemu freezes
>> immediately on startup.
>>
>> (might be due to a rebase?)
>>
> 
> The symptoms, btw, are a vcpu started from 0:0 instead of 0xf000:0xfff0.
> 

Might be unrelated, still: Does [1] make any difference? (Upsream is a
bit hairy ATM.)

Jan

[1] http://thread.gmane.org/gmane.comp.emulators.qemu/75087

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux