From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [patch 6/6] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu Date: Wed, 23 Jun 2010 15:19:46 +0200 Message-ID: <4C2209F2.6030109@siemens.com> References: <20100323163709.033115262@redhat.com> <20100323163812.726785030@redhat.com> <4C21FE28.1040704@redhat.com> <4C21FF20.4030706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:21952 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478Ab0FWNT7 (ORCPT ); Wed, 23 Jun 2010 09:19:59 -0400 In-Reply-To: <4C21FF20.4030706@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 06/23/2010 03:29 PM, Avi Kivity wrote: >> On 03/23/2010 06:37 PM, Marcelo Tosatti wrote: >>> This is now done via the initialization's qemu_system_reset call. >>> >>> >>> Index: qemu-uq/kvm-all.c >>> =================================================================== >>> --- qemu-uq.orig/kvm-all.c >>> +++ qemu-uq/kvm-all.c >>> @@ -209,7 +209,6 @@ int kvm_init_vcpu(CPUState *env) >>> ret = kvm_arch_init_vcpu(env); >>> if (ret == 0) { >>> qemu_register_reset(kvm_reset_vcpu, env); >>> - kvm_arch_reset_vcpu(env); >>> } >>> err: >>> return ret; >>> >>> >> >> I'm testing uq/master, and I see this breaks it. qemu freezes >> immediately on startup. >> >> (might be due to a rebase?) >> > > The symptoms, btw, are a vcpu started from 0:0 instead of 0xf000:0xfff0. > Might be unrelated, still: Does [1] make any difference? (Upsream is a bit hairy ATM.) Jan [1] http://thread.gmane.org/gmane.comp.emulators.qemu/75087 -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux