From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Marcelo Tosatti <mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Takuya Yoshikawa
<yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>,
agraf-l3A5Bk7waGM@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
takuya.yoshikawa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log()
Date: Thu, 24 Jun 2010 11:10:52 +0300 [thread overview]
Message-ID: <4C23130C.8070206@redhat.com> (raw)
In-Reply-To: <20100624005859.GD9388-I4X2Mt4zSy4@public.gmane.org>
On 06/24/2010 03:58 AM, Marcelo Tosatti wrote:
>
>> Well yes, I expect that not using rcu_dereference() (and
>> srcu_read_lock()) is a bug here.
>>
>> Marcelo?
>>
> No because slots_lock is held which serializes with memslot updates.
>
Right, I need to reread Documentation/kvm/locking.txt.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-06-24 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 5:58 [PATCH v2 0/4] KVM: kvm_vm_ioctl_get_dirty_log() fix and cleanup Takuya Yoshikawa
2010-06-23 6:00 ` [PATCH v2 2/4] KVM: ia64: cleanup kvm_ia64_sync_dirty_log() Takuya Yoshikawa
[not found] ` <20100623145807.07a07c4c.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-06-23 5:59 ` [PATCH v2 1/4] KVM: ia64: fix dirty_log_lock spin_lock section not to include get_dirty_log() Takuya Yoshikawa
2010-06-23 6:01 ` [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Takuya Yoshikawa
[not found] ` <20100623150134.9fb5915b.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-06-23 8:48 ` Avi Kivity
[not found] ` <4C21CA5D.4060800-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-23 9:01 ` Takuya Yoshikawa
2010-06-23 9:00 ` Avi Kivity
2010-06-24 0:58 ` Marcelo Tosatti
[not found] ` <20100624005859.GD9388-I4X2Mt4zSy4@public.gmane.org>
2010-06-24 8:10 ` Avi Kivity [this message]
2010-06-25 19:25 ` Alexander Graf
[not found] ` <E5BC6546-6255-4E25-B3DD-F6B6261B6830-l3A5Bk7waGM@public.gmane.org>
2010-06-26 0:38 ` Takuya Yoshikawa
2010-06-26 0:55 ` Takuya Yoshikawa
2010-06-26 9:38 ` Alexander Graf
2010-06-27 7:32 ` Avi Kivity
[not found] ` <4C26FE7B.9090406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28 8:14 ` Takuya Yoshikawa
2010-06-28 9:36 ` Avi Kivity
2010-06-23 6:02 ` [PATCH v2 4/4] KVM: cleanup: make kvm_vm_ioctl_get_dirty_log() arch independent Takuya Yoshikawa
2010-06-23 8:50 ` [PATCH v2 0/4] KVM: kvm_vm_ioctl_get_dirty_log() fix and cleanup Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C23130C.8070206@redhat.com \
--to=avi-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=takuya.yoshikawa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox