From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Date: Thu, 24 Jun 2010 11:10:52 +0300 Message-ID: <4C23130C.8070206@redhat.com> References: <20100623145807.07a07c4c.yoshikawa.takuya@oss.ntt.co.jp> <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> <4C21CA5D.4060800@redhat.com> <4C21CD59.9020000@oss.ntt.co.jp> <4C21CD3F.4030308@redhat.com> <20100624005859.GD9388@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Takuya Yoshikawa , agraf-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, takuya.yoshikawa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Marcelo Tosatti Return-path: In-Reply-To: <20100624005859.GD9388-I4X2Mt4zSy4@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 06/24/2010 03:58 AM, Marcelo Tosatti wrote: > >> Well yes, I expect that not using rcu_dereference() (and >> srcu_read_lock()) is a bug here. >> >> Marcelo? >> > No because slots_lock is held which serializes with memslot updates. > Right, I need to reread Documentation/kvm/locking.txt. -- error compiling committee.c: too many arguments to function