From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Hao\, Xudong" <xudong.hao@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: qemu fail to parse command line with "-pcidevice 00:19.0"
Date: Fri, 25 Jun 2010 15:31:15 +0900 [thread overview]
Message-ID: <4C244D33.3000203@jp.fujitsu.com> (raw)
In-Reply-To: <m3aaqldku4.fsf@blackfin.pond.sub.org>
(2010/06/24 15:08), Markus Armbruster wrote:
> Note to qemu-devel: this issue is qemu-kvm only.
>
> "Hao, Xudong" <xudong.hao@intel.com> writes:
>
>> When assign one PCI device, qemu fail to parse the command line:
>> qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0
>> Error:
>> qemu-system-x86_64: Parameter 'id' expects an identifier
>> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>> pcidevice argument parse error; please check the help text for usage
>> Could not add assigned device host=00:19.0
>>
>> https://bugs.launchpad.net/qemu/+bug/597932
>>
>> This issue caused by qemu-kvm commit b560a9ab9be06afcbb78b3791ab836dad208a239.
>
> The bug is in add_assigned_device():
>
> r = get_param_value(id, sizeof(id), "id", arg);
> if (!r)
> r = get_param_value(id, sizeof(id), "name", arg);
> if (!r)
> r = get_param_value(id, sizeof(id), "host", arg);
>
> We end up with invalid ID "00:19.0".
... Are there any strong reason why we cannot use ':' in the identifier?
Thanks,
H.Seto
next prev parent reply other threads:[~2010-06-25 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 2:03 qemu fail to parse command line with "-pcidevice 00:19.0" Hao, Xudong
2010-06-24 6:08 ` Markus Armbruster
2010-06-25 1:48 ` Hao, Xudong
2010-06-25 4:57 ` Markus Armbruster
2010-06-25 6:30 ` Hao, Xudong
2010-06-25 6:31 ` Hidetoshi Seto [this message]
2010-06-25 8:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C244D33.3000203@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox