From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: qemu fail to parse command line with "-pcidevice 00:19.0"
Date: Fri, 25 Jun 2010 15:31:15 +0900
Message-ID: <4C244D33.3000203@jp.fujitsu.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E084B144F84@shsmsx502.ccr.corp.intel.com> <m3aaqldku4.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Hao\, Xudong" <xudong.hao@intel.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Markus Armbruster <armbru@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:35152 "EHLO
	fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751302Ab0FYGcK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 25 Jun 2010 02:32:10 -0400
Received: from m4.gw.fujitsu.co.jp ([10.0.50.74])
	by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o5P6W8F3001428
	for <kvm@vger.kernel.org> (envelope-from seto.hidetoshi@jp.fujitsu.com);
	Fri, 25 Jun 2010 15:32:08 +0900
Received: from smail (m4 [127.0.0.1])
	by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 92F6B45DE7A
	for <kvm@vger.kernel.org>; Fri, 25 Jun 2010 15:32:08 +0900 (JST)
Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94])
	by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 6DF6B45DE70
	for <kvm@vger.kernel.org>; Fri, 25 Jun 2010 15:32:08 +0900 (JST)
Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1])
	by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 5015B1DB8037
	for <kvm@vger.kernel.org>; Fri, 25 Jun 2010 15:32:08 +0900 (JST)
Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106])
	by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 0B6871DB803F
	for <kvm@vger.kernel.org>; Fri, 25 Jun 2010 15:32:08 +0900 (JST)
In-Reply-To: <m3aaqldku4.fsf@blackfin.pond.sub.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

(2010/06/24 15:08), Markus Armbruster wrote:
> Note to qemu-devel: this issue is qemu-kvm only.
> 
> "Hao, Xudong" <xudong.hao@intel.com> writes:
> 
>> When assign one PCI device, qemu fail to parse the command line:
>> qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0
>> Error:
>> qemu-system-x86_64: Parameter 'id' expects an identifier
>> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>> pcidevice argument parse error; please check the help text for usage
>> Could not add assigned device host=00:19.0
>>
>> https://bugs.launchpad.net/qemu/+bug/597932
>>
>> This issue caused by qemu-kvm commit b560a9ab9be06afcbb78b3791ab836dad208a239.
> 
> The bug is in add_assigned_device():
> 
>     r = get_param_value(id, sizeof(id), "id", arg);
>     if (!r)
>         r = get_param_value(id, sizeof(id), "name", arg);
>     if (!r)
>         r = get_param_value(id, sizeof(id), "host", arg);
> 
> We end up with invalid ID "00:19.0".

... Are there any strong reason why we cannot use ':' in the identifier?


Thanks,
H.Seto