From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Date: Sun, 27 Jun 2010 10:32:11 +0300 Message-ID: <4C26FE7B.9090406@redhat.com> References: <20100623145807.07a07c4c.yoshikawa.takuya@oss.ntt.co.jp> <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Takuya Yoshikawa , mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, takuya.yoshikawa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 06/25/2010 10:25 PM, Alexander Graf wrote: > On 23.06.2010, at 08:01, Takuya Yoshikawa wrote: > > >> kvm_get_dirty_log() is a helper function for kvm_vm_ioctl_get_dirty_log() which >> is currently used by ia64 and ppc and the following is what it is doing: >> >> - sanity checks >> - bitmap scan to check if the slot is dirty >> - copy_to_user() >> >> Considering the fact that x86 is not using this anymore and sanity checks must >> be done before kvm_ia64_sync_dirty_log(), we can say that this is not working >> for code sharing effectively. So we just remove this. >> > This patch plus 4/4 broke dirty bitmap updating on PPC. I didn't get around to track down why, but I figured you should now. Is there any way to get you a PPC development box? A simple G4 or G5 should be 200$ on ebay by now :). > Best to revert these patches and re-apply when fixed. -- error compiling committee.c: too many arguments to function