From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/26] KVM: PPC: Add PV guest critical sections Date: Sun, 27 Jun 2010 14:53:17 +0300 Message-ID: <4C273BAD.2090305@redhat.com> References: <1277508314-915-1-git-send-email-agraf@suse.de> <1277508314-915-9-git-send-email-agraf@suse.de> <4C2709F4.10805@redhat.com> <77DBE095-884F-4986-BE2B-15B2EEAD8CAC@suse.de> <4C271F5A.1030409@redhat.com> <4C272F08.8090709@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm-ppc@vger.kernel.org" , KVM list , linuxppc-dev To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786Ab0F0LxW (ORCPT ); Sun, 27 Jun 2010 07:53:22 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 06/27/2010 02:49 PM, Alexander Graf wrote: > > Am 27.06.2010 um 12:59 schrieb Avi Kivity : > >> On 06/27/2010 01:33 PM, Alexander Graf wrote: >>>> Or inc/dec... >>> >>> >>> Uh - huh? How would that help? >> >> inc shared->critical # disable interrupts > > There is no opcode in the ppc isa that acts on momery without > involving a register. > > An inc would be: > > ld rX, A(0) > addi rX, rX, 1 > std rX, A(0) Right, I was agreeing with you. I meant there was no inc/dec mem insns. -- error compiling committee.c: too many arguments to function