From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v2 1/10] KVM: MMU: fix writable sync sp mapping
Date: Tue, 29 Jun 2010 09:19:26 +0800
Message-ID: <4C294A1E.1070602@cn.fujitsu.com>
References: <4C249B84.4080703@cn.fujitsu.com> <4C2704CF.6040401@cn.fujitsu.com> <4C2868C9.8040302@redhat.com> <4C286E1A.7070003@cn.fujitsu.com> <4C288A6E.6060500@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <4C288A6E.6060500@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



Avi Kivity wrote:

> 
> 
> I think I see.  So, after A, the pages are write protected, but are
> still marked as unsync.  In B, we're testing SP2->unsync, which we plan
> to sync soon, but haven't yet.  So the test for s->unsync is incorrect.
> 

Right.

> So the patch is right.  Thanks for the explanation.  Please update the
> changelog to note that sp->unsync is not reliable during resync, this is
> tricky stuff.
> 

OK, will do it in the next version.