From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [RFC] virtio: Support releasing lock during kick
Date: Tue, 29 Jun 2010 10:12:01 +0300 [thread overview]
Message-ID: <4C299CC1.1020003@redhat.com> (raw)
In-Reply-To: <AANLkTikhPJnw81hhh3PQGSwv7Hkd56YMlOZQM0N-fTLp@mail.gmail.com>
On 06/29/2010 10:08 AM, Stefan Hajnoczi wrote:
>
> Is it incorrect to have the following pattern?
> spin_lock_irqsave(q->queue_lock);
> spin_unlock(q->queue_lock);
> spin_lock(q->queue_lock);
> spin_unlock_irqrestore(q->queue_lock);
>
Perfectly legitimate. spin_lock_irqsave() is equivalent to
local_irq_save() followed by spin_lock() (with the potential
optimization that we can service interrupts while spinning).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-06-29 7:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 21:24 [RFC] virtio: Support releasing lock during kick Stefan Hajnoczi
2010-06-23 22:12 ` Anthony Liguori
2010-06-24 5:30 ` Stefan Hajnoczi
2010-06-25 3:09 ` Rusty Russell
2010-06-25 6:17 ` Stefan Hajnoczi
2010-06-25 10:43 ` Michael S. Tsirkin
2010-06-25 15:31 ` Stefan Hajnoczi
2010-06-25 15:32 ` Michael S. Tsirkin
2010-06-25 16:05 ` Stefan Hajnoczi
2010-06-28 15:55 ` Marcelo Tosatti
2010-06-29 7:08 ` Stefan Hajnoczi
2010-06-29 7:12 ` Avi Kivity [this message]
2011-06-19 7:14 ` Michael S. Tsirkin
2011-06-20 15:27 ` Stefan Hajnoczi
2011-06-24 9:16 ` Stefan Hajnoczi
2011-08-10 13:18 ` Christoph Hellwig
2011-08-10 14:39 ` Stefan Hajnoczi
2011-06-19 7:48 ` Michael S. Tsirkin
2011-06-19 13:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C299CC1.1020003@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox