public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
To: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linuxppc-dev
	<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH] KVM: PPC: Add generic hpte management functions
Date: Tue, 29 Jun 2010 14:56:52 +0200	[thread overview]
Message-ID: <4C29ED94.6060904@suse.de> (raw)
In-Reply-To: <4C286770.6010204-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Avi Kivity wrote:
> On 06/28/2010 11:55 AM, Alexander Graf wrote:
>>
>>>> +
>>>> +static inline u64 kvmppc_mmu_hash_pte(u64 eaddr) {
>>>> +    return hash_64(eaddr>>   PTE_SIZE, HPTEG_HASH_BITS_PTE);
>>>> +}
>>>> +
>>>> +static inline u64 kvmppc_mmu_hash_vpte(u64 vpage) {
>>>> +    return hash_64(vpage&   0xfffffffffULL, HPTEG_HASH_BITS_VPTE);
>>>> +}
>>>> +
>>>> +static inline u64 kvmppc_mmu_hash_vpte_long(u64 vpage) {
>>>> +    return hash_64((vpage&   0xffffff000ULL)>>   12,
>>>> +               HPTEG_HASH_BITS_VPTE_LONG);
>>>> +}
>>>>
>>>>        
>>> Still with the wierd coding style?
>>>      
>> Not sure what's going on there. My editor displays it normally. Weird.
>>    
>
> Try hitting 'save'.

hexdump -C on the respective section in the exact patch file I submitted
above shows:

00000a80  75 72 6e 20 68 61 73 68  5f 36 34 28 65 61 64 64  |urn
hash_64(eadd|
00000a90  72 20 3e 3e 20 50 54 45  5f 53 49 5a 45 2c 20 48  |r >>
PTE_SIZE, H|


Maybe your mail client breaks it?


Alex

  parent reply	other threads:[~2010-06-29 12:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25 23:16 [PATCH] Faster MMU lookups for Book3s Alexander Graf
2010-06-25 23:16 ` [PATCH] KVM: PPC: Add generic hpte management functions Alexander Graf
2010-06-25 23:18   ` Alexander Graf
     [not found]   ` <1277507817-626-2-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-28  8:28     ` Avi Kivity
     [not found]       ` <4C285D1C.5060508-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28  8:55         ` Alexander Graf
     [not found]           ` <20417D40-9345-485B-9201-8B3722B7457F-l3A5Bk7waGM@public.gmane.org>
2010-06-28  9:12             ` Avi Kivity
     [not found]               ` <4C286770.6010204-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28  9:27                 ` Alexander Graf
2010-06-28  9:34                   ` Avi Kivity
     [not found]                     ` <4C286C98.8060903-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28  9:55                       ` Alexander Graf
     [not found]                         ` <4C2871A8.1060706-l3A5Bk7waGM@public.gmane.org>
2010-06-28 10:01                           ` Avi Kivity
     [not found]                             ` <4C2872F5.20501-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28 13:25                               ` Alexander Graf
2010-06-28 13:30                                 ` Avi Kivity
     [not found]                                   ` <4C28A409.9090207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-28 13:32                                     ` Alexander Graf
2010-06-29 12:56                 ` Alexander Graf [this message]
     [not found]                   ` <4C29ED94.6060904-l3A5Bk7waGM@public.gmane.org>
2010-06-29 13:05                     ` Avi Kivity
2010-06-29 13:06                       ` Alexander Graf
2010-06-29 13:13                         ` Avi Kivity
     [not found] ` <1277507817-626-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-25 23:16   ` [PATCH] KVM: PPC: Make use of hash based Shadow MMU Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C29ED94.6060904@suse.de \
    --to=agraf-l3a5bk7wagm@public.gmane.org \
    --cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox