From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF Date: Sat, 03 Jul 2010 16:08:42 +0800 Message-ID: <4C2EF00A.2090406@cn.fujitsu.com> References: <4C2C9DC0.8050607@cn.fujitsu.com> <4C2C9E45.1040304@cn.fujitsu.com> <20100702165432.GB25969@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , LKML , KVM list To: Marcelo Tosatti Return-path: In-Reply-To: <20100702165432.GB25969@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: >> + >> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL)) >> + break; > > BTW, doesnt sync_page also lack reserved bit checking? (unrelated to > this patch). > I think it's not since if EPT is enabled, no unsync page exist, the sync page path can't be trigged. :-)