From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch Date: Sat, 03 Jul 2010 20:57:33 +0800 Message-ID: <4C2F33BD.1030000@cn.fujitsu.com> References: <4C2C9DC0.8050607@cn.fujitsu.com> <4C2C9E6C.2040803@cn.fujitsu.com> <20100702170303.GC25969@amt.cnet> <4C2F117C.2000006@cn.fujitsu.com> <4C2F2835.5060508@redhat.com> <4C2F2A0C.90704@cn.fujitsu.com> <4C2F2C5B.9020503@redhat.com> <4C2F2DBB.50904@cn.fujitsu.com> <4C2F30BD.7050702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM list To: Avi Kivity Return-path: In-Reply-To: <4C2F30BD.7050702@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: >> And this check is not sufficient, since it's only checked if the >> mapping is zapped or not exist, for other words only when broken this >> judgment: >> is_shadow_present_pte(*sptep)&& !is_large_pte(*sptep) >> >> but if the middle level is present and it's not the large mapping, >> this check is skipped. >> > > > Well, in the description, it looked like everything was using small > pages (in kvm, level=1 means PTE level, we need to change this one > day). Please describe again and say exactly when the guest or host uses > large pages. > Avi, sorry for my poor English, i not mean "everything was using small", i don't know where cause you confused :-(