From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch
Date: Sun, 04 Jul 2010 17:32:00 +0300 [thread overview]
Message-ID: <4C309B60.9080502@redhat.com> (raw)
In-Reply-To: <4C2F33BD.1030000@cn.fujitsu.com>
On 07/03/2010 03:57 PM, Xiao Guangrong wrote:
>
> Avi Kivity wrote:
>
>
>>> And this check is not sufficient, since it's only checked if the
>>> mapping is zapped or not exist, for other words only when broken this
>>> judgment:
>>> is_shadow_present_pte(*sptep)&& !is_large_pte(*sptep)
>>>
>>> but if the middle level is present and it's not the large mapping,
>>> this check is skipped.
>>>
>>>
>>
>> Well, in the description, it looked like everything was using small
>> pages (in kvm, level=1 means PTE level, we need to change this one
>> day). Please describe again and say exactly when the guest or host uses
>> large pages.
>>
>>
> Avi, sorry for my poor English, i not mean "everything was using small", i don't
> know where cause you confused :-(
>
Well, LVL1 got me to assume those are small pages.
Can you explain more precisely? Use the processor terms like PTE and
PDE. Don't worry about your English :)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-07-04 14:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 13:53 [PATCH v4 1/6] KVM: MMU: introduce gfn_to_pfn_atomic() function Xiao Guangrong
2010-07-01 13:53 ` [PATCH v4 2/6] KVM: MMU: introduce gfn_to_page_many_atomic() function Xiao Guangrong
2010-07-01 13:54 ` [PATCH v4 3/6] KVM: MMU: introduce pte_prefetch_topup_memory_cache() Xiao Guangrong
2010-07-01 13:55 ` [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF Xiao Guangrong
2010-07-02 16:54 ` Marcelo Tosatti
2010-07-03 8:08 ` Xiao Guangrong
2010-07-05 12:01 ` Marcelo Tosatti
2010-07-06 0:50 ` Xiao Guangrong
2010-07-01 13:55 ` [PATCH v4 5/6] KVM: MMU: combine guest pte read between walk and pte prefetch Xiao Guangrong
2010-07-02 17:03 ` Marcelo Tosatti
2010-07-03 10:31 ` Xiao Guangrong
2010-07-03 12:08 ` Avi Kivity
2010-07-03 12:16 ` Xiao Guangrong
2010-07-03 12:26 ` Avi Kivity
2010-07-03 12:31 ` Xiao Guangrong
2010-07-03 12:44 ` Avi Kivity
2010-07-03 12:49 ` Avi Kivity
2010-07-03 13:03 ` Xiao Guangrong
2010-07-04 14:30 ` Avi Kivity
2010-07-05 2:52 ` Xiao Guangrong
2010-07-05 8:23 ` Avi Kivity
2010-07-05 8:45 ` Xiao Guangrong
2010-07-05 9:05 ` Avi Kivity
2010-07-05 9:09 ` Xiao Guangrong
2010-07-05 9:20 ` Avi Kivity
2010-07-05 9:31 ` Xiao Guangrong
2010-07-03 12:57 ` Xiao Guangrong
2010-07-04 14:32 ` Avi Kivity [this message]
2010-07-03 11:48 ` Avi Kivity
2010-07-01 13:56 ` [PATCH v4 6/6] KVM: MMU: trace " Xiao Guangrong
2010-07-02 16:47 ` [PATCH v4 1/6] KVM: MMU: introduce gfn_to_pfn_atomic() function Marcelo Tosatti
2010-07-03 3:13 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C309B60.9080502@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).