kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH 3/6] KVM: x86 emulator: fix 'and AL,imm8' instruction decoding
Date: Tue, 06 Jul 2010 16:51:09 +0800	[thread overview]
Message-ID: <4C32EE7D.7020103@cn.fujitsu.com> (raw)
In-Reply-To: <4C32EE01.5050408@cn.fujitsu.com>

'and AL,imm8' should be mask as ByteOp, otherwise the dest operand
length will no correct and we may fill the full EAX when writeback.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 arch/x86/kvm/emulate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index ad8d7cd..59568ad 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -123,7 +123,7 @@ static u32 opcode_table[256] = {
 	/* 0x20 - 0x27 */
 	ByteOp | DstMem | SrcReg | ModRM | Lock, DstMem | SrcReg | ModRM | Lock,
 	ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
-	DstAcc | SrcImmByte, DstAcc | SrcImm, 0, 0,
+	ByteOp | DstAcc | SrcImmByte, DstAcc | SrcImm, 0, 0,
 	/* 0x28 - 0x2F */
 	ByteOp | DstMem | SrcReg | ModRM | Lock, DstMem | SrcReg | ModRM | Lock,
 	ByteOp | DstReg | SrcMem | ModRM, DstReg | SrcMem | ModRM,
-- 
1.7.0.4



  parent reply	other threads:[~2010-07-06  8:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06  8:49 [PATCH 1/6] KVM: x86 emulator: fix 'mov sreg,rm16' instruction decoding Wei Yongjun
2010-07-06  8:50 ` [PATCH 2/6] KVM: x86 emulator: fix the comment of out instruction Wei Yongjun
2010-07-06  8:51 ` Wei Yongjun [this message]
2010-07-06  8:52 ` [PATCH 4/6] KVM: x86 emulator: fix 'mov rm,sreg' instruction decoding Wei Yongjun
2010-07-06  8:53 ` [PATCH 5/6] KVM: x86 emulator: fix 'mov AL,moffs' " Wei Yongjun
2010-07-06 11:57   ` Avi Kivity
2010-07-07  6:25     ` Wei Yongjun
2010-07-07  6:26     ` [PATCH] KVM: x86 emulator: re-implementing " Wei Yongjun
2010-07-07  9:33       ` Mohammed Gamal
2010-07-07  9:36         ` Wei Yongjun
2010-07-07  9:43       ` [PATCHv2] " Wei Yongjun
2010-07-07  9:50         ` Avi Kivity
2010-07-06  8:54 ` [PATCH 6/6] KVM: x86 emulator: fix cli/sti instruction emulation Wei Yongjun
2010-07-06  9:22 ` [PATCH 1/6] KVM: x86 emulator: fix 'mov sreg,rm16' instruction decoding Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C32EE7D.7020103@cn.fujitsu.com \
    --to=yjwei@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).