From: Avi Kivity <avi@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 5/6] KVM: x86 emulator: fix 'mov AL,moffs' instruction decoding
Date: Tue, 06 Jul 2010 14:57:07 +0300 [thread overview]
Message-ID: <4C331A13.4020202@redhat.com> (raw)
In-Reply-To: <4C32EF1B.7040709@cn.fujitsu.com>
On 07/06/2010 11:53 AM, Wei Yongjun wrote:
> 'mov AL,moffs' do not need decode dest operand and
> 'mov moffs,AL' do not need decode source operand.
>
>
> @@ -177,8 +177,8 @@ static u32 opcode_table[256] = {
> 0, 0, SrcImmFAddr | No64, 0,
> ImplicitOps | Stack, ImplicitOps | Stack, 0, 0,
> /* 0xA0 - 0xA7 */
> - ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs,
> - ByteOp | DstMem | SrcReg | Mov | MemAbs, DstMem | SrcReg | Mov | MemAbs,
> + ByteOp | SrcMem | Mov | MemAbs, SrcMem | Mov | MemAbs,
> + ByteOp | DstMem | Mov | MemAbs, DstMem | Mov | MemAbs,
> ByteOp | SrcSI | DstDI | Mov | String, SrcSI | DstDI | Mov | String,
> ByteOp | SrcSI | DstDI | String, SrcSI | DstDI | String,
> /* 0xA8 - 0xAF */
>
Autotest rejected this patch (Windows XP fails to install). I think the
reason is that without DstReg, op->type is not initialized and writeback
fails.
I dropped this patch. Suggest re-implementing with DstAcc and (new) SrcAcc.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-07-06 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 8:49 [PATCH 1/6] KVM: x86 emulator: fix 'mov sreg,rm16' instruction decoding Wei Yongjun
2010-07-06 8:50 ` [PATCH 2/6] KVM: x86 emulator: fix the comment of out instruction Wei Yongjun
2010-07-06 8:51 ` [PATCH 3/6] KVM: x86 emulator: fix 'and AL,imm8' instruction decoding Wei Yongjun
2010-07-06 8:52 ` [PATCH 4/6] KVM: x86 emulator: fix 'mov rm,sreg' " Wei Yongjun
2010-07-06 8:53 ` [PATCH 5/6] KVM: x86 emulator: fix 'mov AL,moffs' " Wei Yongjun
2010-07-06 11:57 ` Avi Kivity [this message]
2010-07-07 6:25 ` Wei Yongjun
2010-07-07 6:26 ` [PATCH] KVM: x86 emulator: re-implementing " Wei Yongjun
2010-07-07 9:33 ` Mohammed Gamal
2010-07-07 9:36 ` Wei Yongjun
2010-07-07 9:43 ` [PATCHv2] " Wei Yongjun
2010-07-07 9:50 ` Avi Kivity
2010-07-06 8:54 ` [PATCH 6/6] KVM: x86 emulator: fix cli/sti instruction emulation Wei Yongjun
2010-07-06 9:22 ` [PATCH 1/6] KVM: x86 emulator: fix 'mov sreg,rm16' instruction decoding Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C331A13.4020202@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).