From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Subject: Re: [PATCH 5/6] KVM: x86 emulator: fix 'mov AL,moffs' instruction
 decoding
Date: Wed, 07 Jul 2010 14:25:53 +0800
Message-ID: <4C341DF1.4070409@cn.fujitsu.com>
References: <4C32EE01.5050408@cn.fujitsu.com> <4C32EF1B.7040709@cn.fujitsu.com> <4C331A13.4020202@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:59928 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751098Ab0GGG1u (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 7 Jul 2010 02:27:50 -0400
In-Reply-To: <4C331A13.4020202@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


> On 07/06/2010 11:53 AM, Wei Yongjun wrote:
>   
>> 'mov AL,moffs' do not need decode dest operand and
>> 'mov moffs,AL' do not need decode source operand.
>>
>>
>> @@ -177,8 +177,8 @@ static u32 opcode_table[256] = {
>>  	0, 0, SrcImmFAddr | No64, 0,
>>  	ImplicitOps | Stack, ImplicitOps | Stack, 0, 0,
>>  	/* 0xA0 - 0xA7 */
>> -	ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs,
>> -	ByteOp | DstMem | SrcReg | Mov | MemAbs, DstMem | SrcReg | Mov | MemAbs,
>> +	ByteOp | SrcMem | Mov | MemAbs, SrcMem | Mov | MemAbs,
>> +	ByteOp | DstMem | Mov | MemAbs, DstMem | Mov | MemAbs,
>>  	ByteOp | SrcSI | DstDI | Mov | String, SrcSI | DstDI | Mov | String,
>>  	ByteOp | SrcSI | DstDI | String, SrcSI | DstDI | String,
>>  	/* 0xA8 - 0xAF */
>>   
>>     
> Autotest rejected this patch (Windows XP fails to install). I think the
> reason is that without DstReg, op->type is not initialized and writeback
> fails.
>
>   

> I dropped this patch. Suggest re-implementing with DstAcc and (new) SrcAcc.
>   

sorry about that, I will send a patch to do this.