From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 2/2] KVM: MMU: Keep going on permission error
Date: Wed, 07 Jul 2010 15:41:13 +0300 [thread overview]
Message-ID: <4C3475E9.8040901@redhat.com> (raw)
In-Reply-To: <4C34740D.2070504@siemens.com>
On 07/07/2010 03:33 PM, Jan Kiszka wrote:
> Avi Kivity wrote:
>
>> Real hardware disregards permission errors when computing page fault error
>> code bit 0 (page present). Do the same.
>>
>>
> This generates (false positive) build warnings here:
>
> CC [M] /data/kvm-kmod/x86/coalesced_mmio.o
> /data/kvm-kmod/x86/paging_tmpl.h: In function ‘paging32_walk_addr’:
> /data/kvm-kmod/x86/paging_tmpl.h:122: warning: ‘pte_access’ may be used
> uninitialized in this function
> /data/kvm-kmod/x86/paging_tmpl.h: In function ‘paging64_walk_addr’:
> /data/kvm-kmod/x86/paging_tmpl.h:122: warning: ‘pte_access’ may be used
> uninitialized in this function
>
Yes, I saw. I'll clear it up.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-07-07 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 13:49 [PATCH 0/2] Fix walk_addr() page fault error codes Avi Kivity
2010-07-06 13:49 ` [PATCH 1/2] KVM: MMU: Only indicate a fetch fault in page fault error code if nx is enabled Avi Kivity
2010-07-06 13:49 ` [PATCH 2/2] KVM: MMU: Keep going on permission error Avi Kivity
2010-07-07 12:33 ` Jan Kiszka
2010-07-07 12:41 ` Avi Kivity [this message]
2010-07-08 11:14 ` Jan Kiszka
2010-07-08 11:19 ` Avi Kivity
2010-07-06 21:17 ` [PATCH 0/2] Fix walk_addr() page fault error codes Marcelo Tosatti
2010-07-07 1:49 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3475E9.8040901@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).