From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] KVM: MMU: Keep going on permission error Date: Wed, 07 Jul 2010 15:41:13 +0300 Message-ID: <4C3475E9.8040901@redhat.com> References: <1278424176-15310-1-git-send-email-avi@redhat.com> <1278424176-15310-3-git-send-email-avi@redhat.com> <4C34740D.2070504@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19089 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535Ab0GGMlU (ORCPT ); Wed, 7 Jul 2010 08:41:20 -0400 In-Reply-To: <4C34740D.2070504@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/07/2010 03:33 PM, Jan Kiszka wrote: > Avi Kivity wrote: > =20 >> Real hardware disregards permission errors when computing page fault= error >> code bit 0 (page present). Do the same. >> >> =20 > This generates (false positive) build warnings here: > > CC [M] /data/kvm-kmod/x86/coalesced_mmio.o > /data/kvm-kmod/x86/paging_tmpl.h: In function =E2=80=98paging32_walk_= addr=E2=80=99: > /data/kvm-kmod/x86/paging_tmpl.h:122: warning: =E2=80=98pte_access=E2= =80=99 may be used > uninitialized in this function > /data/kvm-kmod/x86/paging_tmpl.h: In function =E2=80=98paging64_walk_= addr=E2=80=99: > /data/kvm-kmod/x86/paging_tmpl.h:122: warning: =E2=80=98pte_access=E2= =80=99 may be used > uninitialized in this function > =20 Yes, I saw. I'll clear it up. --=20 I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.