From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v5 8/9] KVM: MMU: combine guest pte read between fetch
 and pte prefetch
Date: Wed, 07 Jul 2010 21:11:56 +0800
Message-ID: <4C347D1C.9000100@cn.fujitsu.com>
References: <4C330918.6040709@cn.fujitsu.com> <4C330A9A.9030106@cn.fujitsu.com> <20100706195254.GA4311@amt.cnet> <4C33D703.4090208@cn.fujitsu.com> <20100707130705.GA4293@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:52718 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1755804Ab0GGNPv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 7 Jul 2010 09:15:51 -0400
In-Reply-To: <20100707130705.GA4293@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



Marcelo Tosatti wrote:

>>
>> Below codes read gptes in the prefetch path:
>>
>> 	index = sptep - sp->spt;
>> 	i = index & ~(PTE_PREFETCH_NUM - 1);
>> 	max = index | (PTE_PREFETCH_NUM - 1);
>>
>> 	if (PTTYPE == 32)
>> 		offset = sp->role.quadrant << PT64_LEVEL_BITS;
>>
>> 	first_pte_gpa = gfn_to_gpa(sp->gfn) +
>> 				(offset + i) * sizeof(pt_element_t);
>>
>> 	if (kvm_read_guest_atomic(vcpu->kvm, first_pte_gpa, gptep,
>> 					sizeof(gptep)) < 0)
>> 		return;
>>
>> It reads the 16 aligned items around sptep's corresponding gpte and this gpte
>> is also in this area. :-)
> 
> But you removed that in patch 8?
> 

Oh, i just want it good for review, you mean it's better let patch 7 and 8 in one patch?