From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: Expose MCE control MSRs to userspace Date: Thu, 08 Jul 2010 10:43:39 +0300 Message-ID: <4C3581AB.8030404@redhat.com> References: <1278500979-12725-1-git-send-email-avi@redhat.com> <1278500979-12725-2-git-send-email-avi@redhat.com> <1278554832.2783.2.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Huang Ying Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48511 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614Ab0GHHnl (ORCPT ); Thu, 8 Jul 2010 03:43:41 -0400 In-Reply-To: <1278554832.2783.2.camel@yhuang-dev.sh.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2010 05:07 AM, Huang Ying wrote: > >> static u32 emulated_msrs[] = { >> MSR_IA32_MISC_ENABLE, >> + MSR_IA32_MCG_STATUS, >> + MSR_IA32_MCG_CTL, >> > We need only clear MSR_IA32_MCG_STATUS during reset, but should not > clear MSR_IA32_MCG_CTL. > > Why not? -- error compiling committee.c: too many arguments to function