From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] Reenter guest after instruction emulation failure if emulation was due to access to non-mmio address. Date: Thu, 08 Jul 2010 12:18:55 +0300 Message-ID: <4C3597FF.4050707@redhat.com> References: <1278523006-21645-1-git-send-email-gleb@redhat.com> <1278523006-21645-3-git-send-email-gleb@redhat.com> <4C35950F.8010602@redhat.com> <4C359726.8090908@redhat.com> <20100708091750.GR4689@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754475Ab0GHJS5 (ORCPT ); Thu, 8 Jul 2010 05:18:57 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o689IvCm029426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Jul 2010 05:18:57 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o689Iu4U021244 for ; Thu, 8 Jul 2010 05:18:56 -0400 In-Reply-To: <20100708091750.GR4689@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2010 12:17 PM, Gleb Natapov wrote: > >> btw, that will mean another page walk, so better fold into >> kvm_mmu_unprotect_page_virt() (which needs a new name, since it does >> more than unprotect a page now). >> >> > But this code will be taken very rarely and usually on the way to > failure anyway, do you think additional page walk is a problem? > No, you're right. -- error compiling committee.c: too many arguments to function