From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 6/7] KVM: MMU: Simplify spte fetch() function
Date: Mon, 12 Jul 2010 13:10:58 +0800
Message-ID: <4C3AA3E2.6010307@cn.fujitsu.com>
References: <1278862955-6890-1-git-send-email-avi@redhat.com> <1278862955-6890-7-git-send-email-avi@redhat.com> <4C39EC75.9030502@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:49747 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751198Ab0GLFO4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 12 Jul 2010 01:14:56 -0400
In-Reply-To: <4C39EC75.9030502@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



Avi Kivity wrote:

>> -            }
>> +        validate_direct_spte(vcpu, sptep, direct_access);
>> +
>> +        direct_gfn = gw->gfn&  ~(KVM_PAGES_PER_HPAGE(level) - 1);
>>
>> +        sp = kvm_mmu_get_page(vcpu, direct_gfn, addr, level-1,
>> +                      true, direct_access, sptep);
>>           link_shadow_page(sptep, sp);
>>       }
>>
>>    
> 
> validate_direct_spte() should be before the 'continue' above, probably.
> 

Sure :-)