From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 6/7] KVM: MMU: Simplify spte fetch() function
Date: Mon, 12 Jul 2010 11:52:16 +0300
Message-ID: <4C3AD7C0.8060109@redhat.com>
References: <1278862955-6890-1-git-send-email-avi@redhat.com> <1278862955-6890-7-git-send-email-avi@redhat.com> <4C39EC75.9030502@redhat.com> <4C3AA3E2.6010307@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41734 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754173Ab0GLIwT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 12 Jul 2010 04:52:19 -0400
In-Reply-To: <4C3AA3E2.6010307@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/12/2010 08:10 AM, Xiao Guangrong wrote:
>
> Avi Kivity wrote:
>
>    
>>> -            }
>>> +        validate_direct_spte(vcpu, sptep, direct_access);
>>> +
>>> +        direct_gfn = gw->gfn&   ~(KVM_PAGES_PER_HPAGE(level) - 1);
>>>
>>> +        sp = kvm_mmu_get_page(vcpu, direct_gfn, addr, level-1,
>>> +                      true, direct_access, sptep);
>>>            link_shadow_page(sptep, sp);
>>>        }
>>>
>>>
>>>        
>> validate_direct_spte() should be before the 'continue' above, probably.
>>
>>      
> Sure :-)
>    

Actually, I think this matches current code.  So I'll change it in a 
separate patch.

-- 
error compiling committee.c: too many arguments to function