From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 0/8] Simplify and fix fetch() Date: Mon, 12 Jul 2010 14:42:12 +0300 Message-ID: <4C3AFF94.6040202@redhat.com> References: <1278934254-5598-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Xiao Guangrong , Marcelo Tosatti , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15530 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754368Ab0GLLmQ (ORCPT ); Mon, 12 Jul 2010 07:42:16 -0400 In-Reply-To: <1278934254-5598-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/12/2010 02:30 PM, Avi Kivity wrote: > fetch() has become a monster, with a zillion continues, breaks, and gotos. > Simplify it before Xiao adds even more. > > Also fix the gpte validation race. > A sad side effect is that things are much slower now, since copy_from_user_inatomic() is really slow. I'll look at fixing things up. -- error compiling committee.c: too many arguments to function