From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache() Date: Tue, 13 Jul 2010 12:25:39 +0800 Message-ID: <4C3BEAC3.9000501@cn.fujitsu.com> References: <4C330918.6040709@cn.fujitsu.com> <4C330A37.8080709@cn.fujitsu.com> <4C39C1AB.6000606@redhat.com> <4C3A8694.1000401@cn.fujitsu.com> <4C3B09FD.3060307@redhat.com> <4C3BBE84.30708@cn.fujitsu.com> <4C3BE9BD.40007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM list To: Avi Kivity Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:58217 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750747Ab0GME3k (ORCPT ); Tue, 13 Jul 2010 00:29:40 -0400 In-Reply-To: <4C3BE9BD.40007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 07/13/2010 04:16 AM, Xiao Guangrong wrote: >> >> >>> btw, what about dirty logging? will prefetch cause pages to be marked >>> dirty? >>> >>> We may need to instantiate prefetched pages with spte.d=0 and examine it >>> when tearing down the spte. >>> >>> >> Yeah, all speculative path are broken dirty bit tracking, and i guess >> it's >> need more review, so i plan to do it in the separate patch, i'll post >> it after >> this patchset merged, could you allow it? >> >> > > Regressions? no. Or do you mean the problem already exists? Where? I mean this is a exist problem, likes invlpg, pte-write and sync-page, there are speculative path that it's not real access, but marked dirty if pte is writable.