From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v5 6/9] KVM: MMU: introduce pte_prefetch_topup_memory_cache() Date: Tue, 13 Jul 2010 10:45:03 +0300 Message-ID: <4C3C197F.9050204@redhat.com> References: <4C330918.6040709@cn.fujitsu.com> <4C330A37.8080709@cn.fujitsu.com> <4C39C1AB.6000606@redhat.com> <4C3A8694.1000401@cn.fujitsu.com> <4C3B09FD.3060307@redhat.com> <4C3BBE84.30708@cn.fujitsu.com> <4C3BE9BD.40007@redhat.com> <4C3BEAC3.9000501@cn.fujitsu.com> <4C3BFB25.2010602@redhat.com> <4C3BFE12.4060009@cn.fujitsu.com> <4C3C021E.1000709@redhat.com> <4C3C036B.5060108@cn.fujitsu.com> <4C3C07B6.1020802@redhat.com> <4C3C0D25.6000504@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , LKML , KVM list To: Xiao Guangrong Return-path: In-Reply-To: <4C3C0D25.6000504@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/13/2010 09:52 AM, Xiao Guangrong wrote: >>> >>>> What about the Linux accessed and dirty bits? Need to instantiate the >>>> speculative sptes with accessed and dirty bits clear (and later examine >>>> them when we release the page). >>>> >>>> >>>> >>> I see, will do :-) >>> >>> >> This is getting bigger and bigger... >> >> > What are you worry about? or has fault in this way? :-( > I'm worried about such changes having unforeseen impact, but that's a fact of life, we have to live with it. My other worry is about complexity growing. Every once in a while we need to refactor things so the code remains readable (like I did with the fetch() rewrite). So, keep going, and don't worry about me being worried :) -- error compiling committee.c: too many arguments to function