From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] emulator: inc/dec can have lock prefix
Date: Tue, 13 Jul 2010 16:54:01 +0300 [thread overview]
Message-ID: <4C3C6FF9.6090301@redhat.com> (raw)
In-Reply-To: <20100713134023.GA1891@redhat.com>
On 07/13/2010 04:40 PM, Gleb Natapov wrote:
> Mark inc (0xfe/0 0xff/0) and dec (0xfe/1 0xff/1) as lock prefix capable.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 255473f..b38bd8b 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -345,10 +345,10 @@ static u32 group_table[] = {
> DstMem | SrcNone | ModRM, DstMem | SrcNone | ModRM,
> 0, 0, 0, 0,
> [Group4*8] =
> - ByteOp | DstMem | SrcNone | ModRM, ByteOp | DstMem | SrcNone | ModRM,
> + ByteOp | DstMem | SrcNone | ModRM | Lock, ByteOp | DstMem | SrcNone | ModRM | Lock,
> 0, 0, 0, 0, 0, 0,
> [Group5*8] =
> - DstMem | SrcNone | ModRM, DstMem | SrcNone | ModRM,
> + DstMem | SrcNone | ModRM | Lock, DstMem | SrcNone | ModRM | Lock,
> SrcMem | ModRM | Stack, 0,
> SrcMem | ModRM | Stack, SrcMemFAddr | ModRM | ImplicitOps,
> SrcMem | ModRM | Stack, 0,
>
Right. Please post a regression test as well (kvm/test/x86/emulator.c).
Did this occur on a real workload?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-07-13 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 13:40 [PATCH] emulator: inc/dec can have lock prefix Gleb Natapov
2010-07-13 13:54 ` Avi Kivity [this message]
2010-07-13 13:58 ` Gleb Natapov
2010-07-13 16:52 ` Avi Kivity
2010-07-14 0:09 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3C6FF9.6090301@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox