From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path Date: Wed, 14 Jul 2010 09:08:55 +0800 Message-ID: <4C3D0E27.6050905@cn.fujitsu.com> References: <4C3C3518.7080505@cn.fujitsu.com> <20100713212801.GA6370@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , LKML , KVM list To: Marcelo Tosatti Return-path: In-Reply-To: <20100713212801.GA6370@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: entry = *spte; >> mmu_pte_write_zap_pte(vcpu, sp, spte); >> + >> + if (!!is_pae(vcpu) != sp->role.cr4_pae || >> + is_nx(vcpu) != sp->role.nxe) >> + continue; >> + > > This breaks remote_flush assignment below. Ah, Oops, will fix