From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly Date: Wed, 14 Jul 2010 09:24:22 +0800 Message-ID: <4C3D11C6.4000101@cn.fujitsu.com> References: <4C3C3518.7080505@cn.fujitsu.com> <4C3C35B7.50101@cn.fujitsu.com> <20100713220551.GB6370@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , LKML , KVM list To: Marcelo Tosatti Return-path: In-Reply-To: <20100713220551.GB6370@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > On Tue, Jul 13, 2010 at 05:45:27PM +0800, Xiao Guangrong wrote: >> In speculative path, the page is not real write-access, no need mark it >> dirty, so clear dirty bit in this path and later examine this bit when >> we release the page >> >> Signed-off-by: Xiao Guangrong >> --- >> arch/x86/kvm/mmu.c | 24 +++++++++++------------- >> 1 files changed, 11 insertions(+), 13 deletions(-) > > Unfortunately all pages that kvm creates translations for are marked > dirty due to get_user_pages(w=1), except KSM which makes them read-only > later. Marcelo, i have looked into get_user_pages() function, but not catch where to make page dirty, could you point it out for me? :-)