From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] do not call gva_to_gpa on physical address
Date: Wed, 14 Jul 2010 18:55:45 +0300 [thread overview]
Message-ID: <4C3DDE01.9020705@redhat.com> (raw)
In-Reply-To: <20100714155252.GJ4689@redhat.com>
On 07/14/2010 06:52 PM, Gleb Natapov wrote:
>
>> Why not
>>
>> if (tdp_enabled)
>> return false;
>>
>> at the top? Is there any reason ever to reexecute an instruction
>> with tdp enabled?
>>
>>
> Can't think of one now. If in the future we will shadow some other data
> structures in the guest except page tables (nested vmx/svm?) there may
> be the reason.
>
Sure, we'll adjust it then.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-07-14 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 15:38 [PATCH] do not call gva_to_gpa on physical address Gleb Natapov
2010-07-14 15:44 ` Avi Kivity
2010-07-14 15:52 ` Gleb Natapov
2010-07-14 15:55 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DDE01.9020705@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox