From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Subject: [PATCH] KVM: PPC: fix leakage of page release in kvmppc_patch_dcbz() Date: Thu, 15 Jul 2010 09:35:14 +0800 Message-ID: <4C3E65D2.6060809@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Avi Kivity , Marcelo Tosatti Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:60825 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1758109Ab0GOBhr (ORCPT ); Wed, 14 Jul 2010 21:37:47 -0400 Sender: kvm-owner@vger.kernel.org List-ID: Add kvm_release_page_clean() after is_error_page() to avoid leakage of error page. No test. Signed-off-by: Wei Yongjun --- arch/powerpc/kvm/book3s.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c index a3cef30..5baa3ab 100644 --- a/arch/powerpc/kvm/book3s.c +++ b/arch/powerpc/kvm/book3s.c @@ -415,8 +415,10 @@ static void kvmppc_patch_dcbz(struct kvm_vcpu *vcpu, struct kvmppc_pte *pte) int i; hpage = gfn_to_page(vcpu->kvm, pte->raddr >> PAGE_SHIFT); - if (is_error_page(hpage)) + if (is_error_page(hpage)) { + kvm_release_page_clean(hpage); return; + } hpage_offset = pte->raddr & ~PAGE_MASK; hpage_offset &= ~0xFFFULL; -- 1.7.0.4