From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH 11/18] Perform hardware_enable in CPU_STARTING callback Date: Wed, 14 Jul 2010 22:15:32 -0400 Message-ID: <4C3E6F44.4090007@redhat.com> References: <1278987938-23873-1-git-send-email-zamsden@redhat.com> <1278987938-23873-12-git-send-email-zamsden@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM , Avi Kivity , Marcelo Tosatti , Glauber Costa , Linux-kernel To: Zachary Amsden Return-path: In-Reply-To: <1278987938-23873-12-git-send-email-zamsden@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/12/2010 10:25 PM, Zachary Amsden wrote: > The CPU_STARTING callback was added upstream with the intention > of being used for KVM, specifically for the hardware enablement > that must be done before we can run in hardware virt. It had > bugs on the x86_64 architecture at the time, where it was called > after CPU_ONLINE. The arches have since merged and the bug is > gone. > > It might be noted other features should probably start making > use of this callback; microcode updates in particular which > might be fixing important erratums would be best applied before > beginning to run user tasks. > > Signed-off-by: Zachary Amsden Reviewed-by: Rik van Riel -- All rights reversed