From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lai Jiangshan Subject: [PATCH 1/6] kvm: pass error code to handler Date: Fri, 16 Jul 2010 10:12:53 +0800 Message-ID: <4C3FC025.9070707@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: LKML , kvm@vger.kernel.org, Avi Kivity , Marcelo Tosatti Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org handle_ept_violation() does not pass error code to the handler tdp_page_fault(). It means tdp_page_fault() handles the page fault with ignoring the error code, It will not handle the page fault completely correctly, and may causes endless page fault. Signed-off-by: Lai Jiangshan --- diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 856e427..b40731e 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3521,7 +3521,8 @@ static int handle_ept_violation(struct kvm_vcpu *vcpu) gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS); trace_kvm_page_fault(gpa, exit_qualification); - return kvm_mmu_page_fault(vcpu, gpa & PAGE_MASK, 0); + return kvm_mmu_page_fault(vcpu, gpa & PAGE_MASK, + exit_qualification & 0x2); } static u64 ept_rsvd_mask(u64 spte, int level)