From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/18] Warn about unstable TSC Date: Sun, 18 Jul 2010 17:47:42 +0300 Message-ID: <4C43140E.4070206@redhat.com> References: <1278987938-23873-1-git-send-email-zamsden@redhat.com> <1278987938-23873-6-git-send-email-zamsden@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM , Marcelo Tosatti , Glauber Costa , Linux-kernel To: Zachary Amsden Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30718 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756007Ab0GROrn (ORCPT ); Sun, 18 Jul 2010 10:47:43 -0400 In-Reply-To: <1278987938-23873-6-git-send-email-zamsden@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/13/2010 05:25 AM, Zachary Amsden wrote: > If creating an SMP guest with unstable host TSC, issue a warning > > Signed-off-by: Zachary Amsden > --- > arch/x86/kvm/x86.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 2d5b97a..36ef649 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -5449,6 +5449,10 @@ void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu) > struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, > unsigned int id) > { > + if (check_tsc_unstable()&& id != 0) > + printk_once(KERN_WARNING > + "kvm: SMP vm created on host with unstable TSC; " > + "guest TSC will not be reliable\n"); > return kvm_x86_ops->vcpu_create(kvm, id); > } > > 'id' check not accurate (you can have a uniprocessor guest with id = 1). Better check online_vcpus. -- error compiling committee.c: too many arguments to function