From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] KVM: Non-atomic interrupt injection
Date: Wed, 21 Jul 2010 21:22:57 +0300 [thread overview]
Message-ID: <4C473B01.2030400@redhat.com> (raw)
In-Reply-To: <20100721162700.GB30528@amt.cnet>
On 07/21/2010 07:27 PM, Marcelo Tosatti wrote:
>>
>>> Also should undo vmx.rmode.* ?
>>>
>> Elaborate?
>>
> Undo vmx.rmode assignments on cancel_injection.
>
Hm. Doesn't vmx_complete_interrupts() have to do that anyway if an
injection fails?
Ah:
vmx_vcpu_run()
{
...
vmx->idt_vectoring_info = vmcs_read32(IDT_VECTORING_INFO_FIELD);
if (vmx->rmode.irq.pending)
fixup_rmode_irq(vmx);
...
vmx_complete_interrupts(vmx);
So I'll just move that bit into vmx_complete_interrupts. Good catch.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-07-21 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 13:17 [PATCH v2 0/3] Nonatomic interrupt injection Avi Kivity
2010-07-20 13:17 ` [PATCH v2 1/3] KVM: VMX: Split up vmx_complete_interrupts() Avi Kivity
2010-07-20 13:17 ` [PATCH v2 2/3] KVM: VMX: Parameterize vmx_complete_interrupts() for both exit and entry Avi Kivity
2010-07-20 13:17 ` [PATCH v2 3/3] KVM: Non-atomic interrupt injection Avi Kivity
2010-07-21 0:55 ` Marcelo Tosatti
2010-07-21 5:37 ` Avi Kivity
2010-07-21 16:27 ` Marcelo Tosatti
2010-07-21 18:22 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C473B01.2030400@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox