From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v2 3/3] KVM: Non-atomic interrupt injection
Date: Wed, 21 Jul 2010 21:22:57 +0300
Message-ID: <4C473B01.2030400@redhat.com>
References: <1279631827-4016-1-git-send-email-avi@redhat.com> <1279631827-4016-4-git-send-email-avi@redhat.com> <20100721005533.GA9989@amt.cnet> <4C468796.4060700@redhat.com> <20100721162700.GB30528@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59741 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751170Ab0GUSXD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 Jul 2010 14:23:03 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6LIN3YY030162
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 21 Jul 2010 14:23:03 -0400
In-Reply-To: <20100721162700.GB30528@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/21/2010 07:27 PM, Marcelo Tosatti wrote:
>>
>>> Also should undo vmx.rmode.* ?
>>>        
>> Elaborate?
>>      
> Undo vmx.rmode assignments on cancel_injection.
>    

Hm.  Doesn't vmx_complete_interrupts() have to do that anyway if an 
injection fails?

Ah:

vmx_vcpu_run()
{
...
     vmx->idt_vectoring_info = vmcs_read32(IDT_VECTORING_INFO_FIELD);
     if (vmx->rmode.irq.pending)
         fixup_rmode_irq(vmx);

...

     vmx_complete_interrupts(vmx);

So I'll just move that bit into vmx_complete_interrupts.  Good catch.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.