From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] x86 emulator: Add IRET instruction
Date: Mon, 26 Jul 2010 01:59:12 +0200
Message-ID: <4C4CCFD0.6090203@redhat.com>
References: <1280085618-27368-1-git-send-email-m.gamal005@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org
To: Mohammed Gamal <m.gamal005@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:57971 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752893Ab0GYX7P (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 25 Jul 2010 19:59:15 -0400
Received: by bwz1 with SMTP id 1so2529887bwz.19
        for <kvm@vger.kernel.org>; Sun, 25 Jul 2010 16:59:14 -0700 (PDT)
In-Reply-To: <1280085618-27368-1-git-send-email-m.gamal005@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/25/2010 09:20 PM, Mohammed Gamal wrote:
> +	if (c->op_bytes == 4)
> +		temp_eflags = ((temp_eflags&  0x257fd5) | (ctxt->eflags&  0x1a0000));

Should this do also

if (c->op_bytes == 2)
     temp_eflags = ((temp_eflags & 0x7fd5) | (ctxt->eflags & ~0xffffL));

?

Or better, extract a new function computing the mask from emulate_popf, 
which would do something similar to what I wrote above.

Paolo