From: Avi Kivity <avi@redhat.com>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device
Date: Mon, 26 Jul 2010 22:51:58 +0300 [thread overview]
Message-ID: <4C4DE75E.50507@redhat.com> (raw)
In-Reply-To: <AANLkTi=fGngVkktjrULceOGqXr_goWtLt5AD=oagjm_3@mail.gmail.com>
On 07/26/2010 10:01 PM, Cam Macdonell wrote:
>
>> Is this against qemu.git or qemu-kvm.git? It depends on functions like
>> qemu_ram_map() which are not present in qemu.git (and are present in
>> qemu-kvm.git).
> It is against qemu-kvm.git. Is qemu_ram_map() going into qemu.git?
> Another function I use (and virtio in qemu-kvm uses as well) is
> kvm_set_irqfd() that is not qemu.git either. Do I need ifdef these
> functions with CONFIG_KVM?
>
> Please advise as to how to handle these two functions and then I can
> rebase against qemu.git.
Please add qemu_ram_map() as a separate patch to avoid
interdependencies. Try to keep it at the same place etc., that will
reduce merge difficulties later.
wrt kvm_set_irqfd(), its usage is optional, yes? if so I recommend just
dropping support for it temporarily. I'll work at upstreaming
kvm_set_irqfd() so you can re-add this functionality.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-07-26 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 20:23 [PATCH v7 0/4] Inter-VM shared memory device Cam Macdonell
2010-06-15 20:23 ` [PATCH v7 1/4] Device specification for shared memory PCI device Cam Macdonell
2010-06-15 20:23 ` [PATCH v7 2/4] Add function to assign ioeventfd to MMIO Cam Macdonell
2010-06-15 20:23 ` [PATCH v7 3/4] Support marking a device as non-migratable Cam Macdonell
2010-06-15 20:23 ` [PATCH v7 4/4] Inter-VM shared memory PCI device Cam Macdonell
2010-06-23 15:57 ` [PATCH v7 RESEND " Cam Macdonell
2010-07-08 21:08 ` Cam Macdonell
2010-07-08 23:45 ` David S. Ahern
2010-07-26 13:48 ` [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device Anthony Liguori
2010-07-26 19:01 ` Cam Macdonell
2010-07-26 19:41 ` Anthony Liguori
2010-07-26 20:27 ` Avi Kivity
2010-07-26 20:41 ` Anthony Liguori
2010-07-26 21:46 ` Cam Macdonell
2010-07-26 22:18 ` Anthony Liguori
2010-07-26 19:51 ` Avi Kivity [this message]
2010-07-26 20:03 ` Cam Macdonell
2010-07-26 20:11 ` Avi Kivity
2010-07-26 20:16 ` Cam Macdonell
2010-07-26 20:20 ` Avi Kivity
2010-07-26 20:05 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4DE75E.50507@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=cam@cs.ualberta.ca \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox