From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device Date: Mon, 26 Jul 2010 22:51:58 +0300 Message-ID: <4C4DE75E.50507@redhat.com> References: <1276633426-30995-1-git-send-email-cam@cs.ualberta.ca> <4C4D922C.3020608@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Cam Macdonell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8737 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626Ab0GZTwG (ORCPT ); Mon, 26 Jul 2010 15:52:06 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2010 10:01 PM, Cam Macdonell wrote: > >> Is this against qemu.git or qemu-kvm.git? It depends on functions like >> qemu_ram_map() which are not present in qemu.git (and are present in >> qemu-kvm.git). > It is against qemu-kvm.git. Is qemu_ram_map() going into qemu.git? > Another function I use (and virtio in qemu-kvm uses as well) is > kvm_set_irqfd() that is not qemu.git either. Do I need ifdef these > functions with CONFIG_KVM? > > Please advise as to how to handle these two functions and then I can > rebase against qemu.git. Please add qemu_ram_map() as a separate patch to avoid interdependencies. Try to keep it at the same place etc., that will reduce merge difficulties later. wrt kvm_set_irqfd(), its usage is optional, yes? if so I recommend just dropping support for it temporarily. I'll work at upstreaming kvm_set_irqfd() so you can re-add this functionality. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.