From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device Date: Mon, 26 Jul 2010 15:05:55 -0500 Message-ID: <4C4DEAA3.8090000@codemonkey.ws> References: <1276633426-30995-1-git-send-email-cam@cs.ualberta.ca> <4C4D922C.3020608@codemonkey.ws> <4C4DE75E.50507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Cam Macdonell , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:60584 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538Ab0GZUF7 (ORCPT ); Mon, 26 Jul 2010 16:05:59 -0400 Received: by yxg6 with SMTP id 6so215606yxg.19 for ; Mon, 26 Jul 2010 13:05:58 -0700 (PDT) In-Reply-To: <4C4DE75E.50507@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2010 02:51 PM, Avi Kivity wrote: > On 07/26/2010 10:01 PM, Cam Macdonell wrote: >> >>> Is this against qemu.git or qemu-kvm.git? It depends on functions like >>> qemu_ram_map() which are not present in qemu.git (and are present in >>> qemu-kvm.git). >> It is against qemu-kvm.git. Is qemu_ram_map() going into qemu.git? >> Another function I use (and virtio in qemu-kvm uses as well) is >> kvm_set_irqfd() that is not qemu.git either. Do I need ifdef these >> functions with CONFIG_KVM? >> >> Please advise as to how to handle these two functions and then I can >> rebase against qemu.git. > > Please add qemu_ram_map() as a separate patch to avoid > interdependencies. Try to keep it at the same place etc., that will > reduce merge difficulties later. Oh, qemu_ram_map() has a horrible name. It should be qemu_ram_alloc_from_ptr(). Otherwise, I agree with Avi. Regards, Anthony Liguori > wrt kvm_set_irqfd(), its usage is optional, yes? if so I recommend > just dropping support for it temporarily. I'll work at upstreaming > kvm_set_irqfd() so you can re-add this functionality. >