From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH v7 0/4] Inter-VM shared memory device Date: Mon, 26 Jul 2010 23:27:41 +0300 Message-ID: <4C4DEFBD.9000700@redhat.com> References: <1276633426-30995-1-git-send-email-cam@cs.ualberta.ca> <4C4D922C.3020608@codemonkey.ws> <4C4DE501.2080202@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Cam Macdonell , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754834Ab0GZU1s (ORCPT ); Mon, 26 Jul 2010 16:27:48 -0400 In-Reply-To: <4C4DE501.2080202@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 07/26/2010 10:41 PM, Anthony Liguori wrote: > > kvm_set_irqfd() is fine, it just needs to be ported. It should be > there due to vhost though? > It should, but isn't. > qemu_ram_map() is more difficult. I would think the better approach > would be to invert things. Instead of a "give me a stable mapping > that is shared atomically with a guest to this ram region", I would go > with "go create a ram region with this preallocated memory" and then > just assume that afterwards, you can make use of it and it's exposed > as atomic memory. Isn't that what qemu_ram_map() does? > ram_addr_t qemu_ram_map(DeviceState *dev, const char *name, > ram_addr_t size, void *host) 'host' is your "this preallocated memory", no? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.