public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] test: Add emulator test for iret instruction
Date: Wed, 28 Jul 2010 07:21:51 +0300	[thread overview]
Message-ID: <4C4FB05F.7060301@redhat.com> (raw)
In-Reply-To: <1280272922-1997-1-git-send-email-m.gamal005@gmail.com>

  On 07/28/2010 02:22 AM, Mohammed Gamal wrote:
> This adds a unit test for real mode emulation of the iret instruction
>
> Signed-off-by: Mohammed Gamal<m.gamal005@gmail.com>
> ---
>   kvm/test/x86/realmode.c |   23 +++++++++++++++++++++++
>   1 files changed, 23 insertions(+), 0 deletions(-)
>
> diff --git a/kvm/test/x86/realmode.c b/kvm/test/x86/realmode.c
> index bd79348..16716cc 100644
> --- a/kvm/test/x86/realmode.c
> +++ b/kvm/test/x86/realmode.c
> @@ -865,6 +865,28 @@ void test_pusha_popa()
>   		print_serial("Pusha/Popa Test2: PASS\n");
>   }
>
> +void test_iret()
> +{
> +	struct regs inregs = { 0 }, outregs;
> +
> +	MK_INSN(iret, "pushf\n\t"
> +		      "pushl %cs\n\t"
> +		      "call 1f\n\t" /* a near call will push eip onto the stack */
> +		      "jmp 2f\n\t"
> +		      "1:iret\n\t"
> +		      "2:\n\t"
> +		     );
> +
> +	exec_in_big_real_mode(&inregs,&outregs,
> +			      insn_iret,
> +			      insn_iret_end - insn_iret);
> +
> +	if (!regs_equal(&inregs,&outregs, 0))
> +		print_serial("iret Test 1: FAIL\n");
> +	else
> +		print_serial("iret Test 1: PASS\n");
> +}
> +

This tests 32-bit iret, please test 16-bit iret as well (pushfw, pushw 
cs, callw, iretw).

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2010-07-28  4:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 23:22 [PATCH] test: Add emulator test for iret instruction Mohammed Gamal
2010-07-28  4:21 ` Avi Kivity [this message]
2010-07-28  4:28   ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-07-28  9:39 Mohammed Gamal
2010-07-28 19:55 ` Marcelo Tosatti
2010-07-28 20:28   ` Mohammed Gamal
2010-07-28 20:32     ` Marcelo Tosatti
2010-07-28 20:36       ` Mohammed Gamal
     [not found]         ` <20100728205627.GA31469@amt.cnet>
     [not found]           ` <AANLkTi=tguT3Y2qStz-Z31HQF684VDiG=gomJfB34AJj@mail.gmail.com>
2010-07-28 23:16             ` Mohammed Gamal
2010-07-28 23:18               ` Mohammed Gamal
2010-07-29  1:21                 ` Marcelo Tosatti
2010-07-29 15:50 ` Marcelo Tosatti
2010-07-27 23:03 Mohammed Gamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4FB05F.7060301@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=m.gamal005@gmail.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox