From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Use kvm32/kvm64 as default CPUs when running under KVM.
Date: Wed, 28 Jul 2010 12:57:12 +0200 [thread overview]
Message-ID: <4C500D08.7050304@redhat.com> (raw)
In-Reply-To: <4C500BC6.6020900@redhat.com>
On 07/28/10 12:51, Avi Kivity wrote:
> On 07/28/2010 01:05 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> KVM has a minimum CPU requirement in order to run, so there is no
>> reason to default to the very basic family 6, model 2 (or model 3 for
>> qemu32) CPU since the additional features are going to be available on
>> the host CPU.
>>
>>
>> @@ -866,11 +867,19 @@ void pc_cpus_init(const char *cpu_model)
>>
>> /* init CPUs */
>> if (cpu_model == NULL) {
>> + if (kvm_enabled()) {
>> #ifdef TARGET_X86_64
>> - cpu_model = "qemu64";
>> + cpu_model = "kvm64";
>> #else
>> - cpu_model = "qemu32";
>> + cpu_model = "kvm32";
>> #endif
>> + } else {
>> +#ifdef TARGET_X86_64
>> + cpu_model = "qemu64";
>> +#else
>> + cpu_model = "qemu32";
>> +#endif
>> + }
>> }
>
> What about -M 0.12? It needs to retain the old values.
>
Urgh, good point. I'll come up with a fix for that. So much for a simple
patch :)
Jes
prev parent reply other threads:[~2010-07-28 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 10:05 [PATCH] Use kvm32/kvm64 as default CPUs when running under KVM Jes.Sorensen
2010-07-28 10:51 ` [Qemu-devel] " Avi Kivity
2010-07-28 10:57 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C500D08.7050304@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox