From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [Qemu-devel] [PATCH] Use kvm32/kvm64 as default CPUs when running under KVM. Date: Wed, 28 Jul 2010 12:57:12 +0200 Message-ID: <4C500D08.7050304@redhat.com> References: <1280311527-2650-1-git-send-email-Jes.Sorensen@redhat.com> <4C500BC6.6020900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52679 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754610Ab0G1K5R (ORCPT ); Wed, 28 Jul 2010 06:57:17 -0400 In-Reply-To: <4C500BC6.6020900@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/28/10 12:51, Avi Kivity wrote: > On 07/28/2010 01:05 PM, Jes.Sorensen@redhat.com wrote: >> From: Jes Sorensen >> >> KVM has a minimum CPU requirement in order to run, so there is no >> reason to default to the very basic family 6, model 2 (or model 3 for >> qemu32) CPU since the additional features are going to be available on >> the host CPU. >> >> >> @@ -866,11 +867,19 @@ void pc_cpus_init(const char *cpu_model) >> >> /* init CPUs */ >> if (cpu_model == NULL) { >> + if (kvm_enabled()) { >> #ifdef TARGET_X86_64 >> - cpu_model = "qemu64"; >> + cpu_model = "kvm64"; >> #else >> - cpu_model = "qemu32"; >> + cpu_model = "kvm32"; >> #endif >> + } else { >> +#ifdef TARGET_X86_64 >> + cpu_model = "qemu64"; >> +#else >> + cpu_model = "qemu32"; >> +#endif >> + } >> } > > What about -M 0.12? It needs to retain the old values. > Urgh, good point. I'll come up with a fix for that. So much for a simple patch :) Jes